Logging typos fixed, maybe one error code definition too #12054
Conversation
|
Can one of the admins verify this patch? |
|
test this please |
|
Jenkins results:
|
There was a problem hiding this comment.
These changes are looking good to me as well, but there is one module that needs to be updated (please see my comment along the code).
Once you make that change, could you please squash the new commit into the first one? In case you need some directions on that process, I find this https://steveklabnik.com/writing/how-to-squash-commits-in-a-github-pull-request a good source. Thank you again!
|
Hello. Fixed now, if you meant for the 2nd commit to remain separate. |
|
Great, thanks Fredrik! |
Fixes #12051
Status
not-tested
Description
Fixes some logging output typos, that seem not have been hardcoded into parsing code elsewhere on github (except for the second commit with 'woud's ).
Is WMCore/Agent/Flow/DefaultFlow.py used at all? I only saw it in a help output from the flow generation as a default file to modify to your own needs, not run as is? If you want, I could cherry-pick the commits from master...oljemark:WMCore:twiki-codes to this PR - the error code typo fix would also need simultaneous fix in the TWiki.
Is it backward compatible (if not, which system it affects?)
MAYBE
Related PRs
External dependencies / deployment changes